lkml.org 
[lkml]   [2018]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 12 Mar 2018, Jason Vas Dias wrote:
>
> checkpatch.pl still reports:
>
> total: 15 errors, 3 warnings, 165 lines checked
>
> > +notrace static u64 vread_tsc_raw(void)
> > +{
> > + u64 tsc, last=gtod->raw_cycle_last;
> > + if( likely( gtod->has_rdtscp ) )
> > + tsc = rdtscp((void*)0);
>
> Plus I asked more than once to split that rdtscp() stuff into a separate
> patch.
>
> You surely are free to ignore my review comments, but rest assured that I'm
> free to ignore the crap you insist to send me as well.

In addition to Thomas's review feedback I'd strongly urge the careful reading of
Documentation/SubmittingPatches as well:

- When sending multiple patches please use git-send-mail

- Please don't send several patch iterations per day!

- Code quality of the submitted patches is atrocious, please run them through
scripts/checkpatch.pl (and make sure they pass) to at least enable the reading
of them.

- ... plus dozens of other details described in Documentation/SubmittingPatches.

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-03-12 08:24    [W:0.070 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site