lkml.org 
[lkml]   [2018]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/2] rtc: s5m: Remove VLA usage
    On Sat, Mar 10, 2018 at 7:27 AM, Gustavo A. R. Silva
    <gustavo@embeddedor.com> wrote:
    > In preparation to enabling -Wvla, remove VLAs and replace them
    > with fixed-length arrays instead.
    >
    > From a security viewpoint, the use of Variable Length Arrays can be
    > a vector for stack overflow attacks. Also, in general, as the code
    > evolves it is easy to lose track of how big a VLA can get. Thus, we
    > can end up having segfaults that are hard to debug.
    >
    > Also, fixed as part of the directive to remove all VLAs from
    > the kernel: https://lkml.org/lkml/2018/3/7/621
    >
    > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    > ---
    > drivers/rtc/rtc-s5m.c | 14 ++++++++------
    > 1 file changed, 8 insertions(+), 6 deletions(-)


    Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2018-03-12 12:14    [W:2.262 / U:0.676 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site