Messages in this thread | | | From | Ilya Dryomov <> | Date | Mon, 12 Mar 2018 10:57:08 +0100 | Subject | Re: [PATCH] rbd: Remove VLA stack usage |
| |
On Mon, Mar 12, 2018 at 6:06 AM, Tobin C. Harding <me@tobin.cc> wrote: > On Sun, Mar 11, 2018 at 10:02:04PM -0700, Eric Biggers wrote: >> On Mon, Mar 12, 2018 at 03:49:40PM +1100, Tobin C. Harding wrote: >> > The kernel would like to have all stack VLA usage removed[1]. >> >> Can you please stop writing this? The Linux kernel isn't sentient; it doesn't >> "like" anything. You need to explain why *you* (and other people) believe these >> changes should be made. > > No worries, will re-spin with better description.
I'd prefer a single patch covering both functions.
Also, as these are char arrays, use sizeof instead of ARRAY_SIZE.
Thanks,
Ilya
| |