Messages in this thread | | | Date | Mon, 12 Mar 2018 01:04:02 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 08/13] PCI/portdrv: Simplify PCIe feature permission checking |
| |
> + * We assume we can manage these PCIe features. Some systems may > + * reserve these for use by the platform itself, e.g., an ACPI BIOS > + * may implement its own AER handling and use _OSC to prevent the > + * OS from interfering. > + */ > + bridge->use_aer = 1; > + bridge->use_hotplug = 1; > + bridge->use_pme = 1;
If we start out with enabled maybe these should be disable_foo flags instead?
Also please use bool (or a bitfield bool) for true/false values.
| |