lkml.org 
[lkml]   [2018]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 03/20] test_firmware: replace syfs fallback check with kconfig_has helper
    Date
    Now that we have a kconfig checker just use that instead of relying
    on testing a sysfs directory being present, since our requirements
    are spelled out.

    Acked-by: Kees Cook <keescook@chromium.org>
    Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
    ---
    tools/testing/selftests/firmware/fw_fallback.sh | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/tools/testing/selftests/firmware/fw_fallback.sh b/tools/testing/selftests/firmware/fw_fallback.sh
    index bf850050e5e9..323c921a2469 100755
    --- a/tools/testing/selftests/firmware/fw_fallback.sh
    +++ b/tools/testing/selftests/firmware/fw_fallback.sh
    @@ -11,10 +11,7 @@ source $TEST_DIR/fw_lib.sh

    check_mods

    -# CONFIG_FW_LOADER_USER_HELPER has a sysfs class under /sys/class/firmware/
    -# These days no one enables CONFIG_FW_LOADER_USER_HELPER so check for that
    -# as an indicator for CONFIG_FW_LOADER_USER_HELPER.
    -HAS_FW_LOADER_USER_HELPER=$(if [ -d /sys/class/firmware/ ]; then echo yes; else echo no; fi)
    +HAS_FW_LOADER_USER_HELPER=$(kconfig_has CONFIG_FW_LOADER_USER_HELPER=y)
    HAS_FW_LOADER_USER_HELPER_FALLBACK=$(kconfig_has CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y)

    if [ "$HAS_FW_LOADER_USER_HELPER" = "yes" ]; then
    --
    2.16.2
    \
     
     \ /
      Last update: 2018-03-10 15:22    [W:4.098 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site