Messages in this thread | | | From | Milian Wolff <> | Subject | Re: [RFC PATCH] perf/core: exposing type of context-switch-out event | Date | Thu, 01 Mar 2018 20:19:47 +0100 |
| |
On Donnerstag, 1. März 2018 19:08:05 CET Andi Kleen wrote: > On Thu, Mar 01, 2018 at 06:40:04PM +0300, Alexey Budankov wrote: > > Hi, > > > > This patch prototypes exposing the type of context-switch-out event using > > PERF_RECORD_MISC_EXT_RESERVED bit for PERF_RECORD_SWITCH[_CPU_WIDE] > > records. > It would be better to define an actually named bit in perf_event.h. > It can be the same value. > > Also we would need a patch for perf script / perf report -D to print this > information. > > The rest looks good to me.
Please also add documentation Documentation/perf.data-file-format.txt, but I just noticed that not even PERF_RECORD_SWITCH is documented there...
Otherwise I also think that this would be a very nice feature addition!
-- Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt, C++ and OpenGL Experts[unhandled content-type:application/pkcs7-signature] | |