[lkml]   [2018]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] printk: move dump stack related code to lib/dump_stack.c
On 02/09/18 at 05:42pm, Sergey Senozhatsky wrote:
> On (02/09/18 16:27), Dave Young wrote:
> > > Seems that those functions are still defined in printk header.
> > > Did you test !CONFIG_PRINTK build?
> Apparently dump_stack(void) is also in printk.h
> extern asmlinkage void dump_stack(void) __cold;
> so it's "OK" to keep those functions in printk.h, I guess. I thought
> that dump_stack() had its own header file...

It has not unfortunately.. The build failed because we have dummy
functions in printk.h and redefined in lib/dump_stack.c. I'm hesitating
to add #ifdef CONFIG_PRINTK in lib/dump_stack.c.

> > !CONFIG_PRINTK will use the dummy functions in printk.h, I did not test
> > the build, doing it now to double confirm..
> Not sure. Please test.
> -ss


 \ /
  Last update: 2018-02-09 09:51    [W:0.049 / U:1.748 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site