Messages in this thread | | | Date | Fri, 9 Feb 2018 20:02:26 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 09/31] x86/entry/32: Leave the kernel via trampoline stack |
| |
On Fri, Feb 09, 2018 at 09:05:02AM -0800, Linus Torvalds wrote: > On Fri, Feb 9, 2018 at 1:25 AM, Joerg Roedel <joro@8bytes.org> wrote: > > + > > + /* Copy over the stack-frame */ > > + cld > > + rep movsb > > Ugh. This is going to be horrendous. Maybe not noticeable on modern > CPU's, but the whole 32-bit code is kind of pointless on a modern CPU. > > At least use "rep movsl". If the kernel stack isn't 4-byte aligned, > you have issues.
Okay, I used movsb because I remembered that being the recommendation for the most efficient memcpy, and it safes me an instruction. But that is probably only true on modern CPUs. I'll change it to use movsl here and in the other patches.
Thanks,
Joerg
| |