lkml.org 
[lkml]   [2018]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: net: thunder: change q_len's type to handle max ring size
From
Date
On 02/08/2018 10:29 PM, Sunil Kovvuri wrote:
> On Fri, Feb 9, 2018 at 3:27 AM, Dean Nelson <dnelson@redhat.com> wrote:
>> On 02/08/2018 02:34 PM, David Miller wrote:
>>>
>>> From: Dean Nelson <dnelson@redhat.com>
>>> Date:
>>>
>>>> The Cavium thunder nicvf driver supports rx/tx rings of up to 65536
>>>> entries per.
...
>>>
>>> Another way to solve this could have been to encode that length
>>> as "length - 1"
>>
>>
>> True. I had pondered that, but felt that since changing q_len's type
>> didn't add any length to the structure and that it was less impactful
>> from a number-of-lines of code changed perspective, I'd opt for this
>> route.
>>
>> Cavium, if you'd prefer this goes the route that Dave just mentioned,
>> please let me know and I can make a new patch against what's been
>> applied?
>
> Thanks for fixing this and i think the current patch is fine.

You're welcome. And thanks for responding. So I'll leave things as they
are.

\
 
 \ /
  Last update: 2018-02-09 13:53    [W:0.038 / U:0.016 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site