lkml.org 
[lkml]   [2018]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select
From
On Sun, 04 Feb 2018 17:30:57 PST (-0800), ulfalizer@gmail.com wrote:
> On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
>> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743
>> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should
>> just be selected explicitly if needed.
>>
>> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV.
>>
>> See commit 0145071b3314 ("x86: Do away with
>> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do
>> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well.
>>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>> arch/riscv/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>> index ff69c77b9e78..716e90e60e5c 100644
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -19,7 +19,6 @@ config RISCV
>> select GENERIC_STRNLEN_USER
>> select GENERIC_SMP_IDLE_THREAD
>> select GENERIC_ATOMIC64 if !64BIT || !RISCV_ISA_A
>> - select ARCH_WANT_OPTIONAL_GPIOLIB
>> select HAVE_MEMBLOCK
>> select HAVE_MEMBLOCK_NODE_MAP
>> select HAVE_DMA_API_DEBUG
>> --
>> 2.14.1
>>
>
> There's also a select of a globally undefined symbol RISCV_IRQ_INTC
> here. I couldn't dig up any historical or unmerged definition for it
> either. Googling just gets you the select.

It looks like this slipped through, the symbol has been renamed RISCV_INTC. A
patch to remove it is

Reviewed-by: Palmer Dabbelt <palmer@sifive.com>

(and like the other ones, if you want it through my tree just say something)

\
 
 \ /
  Last update: 2018-02-08 21:51    [W:0.133 / U:31.164 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site