lkml.org 
[lkml]   [2018]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] selftests/android: Fix line continuation in Makefile
On Wed, Feb 7, 2018 at 5:22 AM, Daniel Díaz <daniel.diaz@linaro.org> wrote:
> The Makefile lacks a couple of line continuation backslashes
> in an `if' clause, which can make the subsequent rsync
> command go awry over the whole filesystem (`rsync -a / /`).
>
> /bin/sh: -c: line 5: syntax error: unexpected end of file
> make[1]: [all] Error 1 (ignored)
> TEST=$DIR"_test.sh"; \
> if [ -e $DIR/$TEST ]; then
> /bin/sh: -c: line 2: syntax error: unexpected end of file
> make[1]: [all] Error 1 (ignored)
> rsync -a $DIR/$TEST $BUILD_TARGET/;
> [...a myriad of:]
> [ rsync: readlink_stat("...") failed: Permission denied (13)]
> [ skipping non-regular file "..."]
> [ rsync: opendir "..." failed: Permission denied (13)]
> [and many other errors...]
> fi
> make[1]: fi: Command not found
> make[1]: [all] Error 127 (ignored)
> done
> make[1]: done: Command not found
> make[1]: [all] Error 127 (ignored)
>
> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> ---
> tools/testing/selftests/android/Makefile | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/android/Makefile b/tools/testing/selftests/android/Makefile
> index 1a74922..f6304d2 100644
> --- a/tools/testing/selftests/android/Makefile
> +++ b/tools/testing/selftests/android/Makefile
> @@ -11,11 +11,11 @@ all:
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> mkdir $$BUILD_TARGET -p; \
> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> - #SUBDIR test prog name should be in the form: SUBDIR_test.sh
> + #SUBDIR test prog name should be in the form: SUBDIR_test.sh \
> TEST=$$DIR"_test.sh"; \
> - if [ -e $$DIR/$$TEST ]; then
> - rsync -a $$DIR/$$TEST $$BUILD_TARGET/;
> - fi
> + if [ -e $$DIR/$$TEST ]; then \
> + rsync -a $$DIR/$$TEST $$BUILD_TARGET/; \
> + fi \
> done
>
> override define RUN_TESTS

Acked-by: Pintu Agarwal <pintu.ping@gmail.com>

> --
> 2.7.4
>

\
 
 \ /
  Last update: 2018-02-08 06:17    [W:0.052 / U:3.548 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site