lkml.org 
[lkml]   [2018]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 13/14] kconfig: test: check if recursive dependencies are detected
On Tue, Feb 6, 2018 at 1:34 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Recursive dependency should be detected and warned. Test this.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> scripts/kconfig/tests/warn_recursive_dep/Kconfig | 62 ++++++++++++++++++++++
> .../kconfig/tests/warn_recursive_dep/__init__.py | 10 ++++
> .../tests/warn_recursive_dep/expected_stderr | 33 ++++++++++++
> 3 files changed, 105 insertions(+)
> create mode 100644 scripts/kconfig/tests/warn_recursive_dep/Kconfig
> create mode 100644 scripts/kconfig/tests/warn_recursive_dep/__init__.py
> create mode 100644 scripts/kconfig/tests/warn_recursive_dep/expected_stderr
>
> diff --git a/scripts/kconfig/tests/warn_recursive_dep/Kconfig b/scripts/kconfig/tests/warn_recursive_dep/Kconfig
> new file mode 100644
> index 0000000..9ab2474
> --- /dev/null
> +++ b/scripts/kconfig/tests/warn_recursive_dep/Kconfig
> @@ -0,0 +1,62 @@
> +# depends on itself
> +
> +config A
> + bool "A"
> + depends on A
> +
> +# select itself
> +
> +config B
> + bool
> + select B
> +
> +# depends on each other
> +
> +config C1
> + bool "C1

Missing end quote here. Noticed because the output contains
"Kconfig:16:warning: multi-line strings not supported". :)

> + depends on C2
> +
> +config C2
> + bool "C2"
> + depends on C1
> +
> +# depends on and select
> +
> +config D1
> + bool "D1"
> + depends on D2
> + select D2
> +
> +config D2
> + bool
> +
> +# depends on and imply
> +# This is not recursive dependency
> +
> +config E1
> + bool "E1"
> + depends on E2
> + imply E2
> +
> +config E2
> + bool "E2"
> +
> +# property
> +
> +config F1
> + bool "F1"
> + default F2
> +
> +config F2
> + bool "F2"
> + depends on F1
> +
> +# menu
> +
> +menu "menu depending on its content"
> + depends on G
> +
> +config G
> + bool "G"
> +
> +endmenu
> diff --git a/scripts/kconfig/tests/warn_recursive_dep/__init__.py b/scripts/kconfig/tests/warn_recursive_dep/__init__.py
> new file mode 100644
> index 0000000..cdf2c13
> --- /dev/null
> +++ b/scripts/kconfig/tests/warn_recursive_dep/__init__.py
> @@ -0,0 +1,10 @@
> +"""
> +Warn recursive inclusion
> +========================
> +
> +Recursive dependency should be warned.
> +"""
> +
> +def test(conf):
> + assert conf.oldaskconfig() == 0
> + assert conf.stderr_contains('expected_stderr')
> diff --git a/scripts/kconfig/tests/warn_recursive_dep/expected_stderr b/scripts/kconfig/tests/warn_recursive_dep/expected_stderr
> new file mode 100644
> index 0000000..ea47cae
> --- /dev/null
> +++ b/scripts/kconfig/tests/warn_recursive_dep/expected_stderr
> @@ -0,0 +1,33 @@
> +Kconfig:16:warning: multi-line strings not supported
> +Kconfig:9:error: recursive dependency detected!
> +Kconfig:9: symbol B is selected by B
> +For a resolution refer to Documentation/kbuild/kconfig-language.txt
> +subsection "Kconfig recursive dependency limitations"
> +
> +Kconfig:3:error: recursive dependency detected!
> +Kconfig:3: symbol A depends on A
> +For a resolution refer to Documentation/kbuild/kconfig-language.txt
> +subsection "Kconfig recursive dependency limitations"
> +
> +Kconfig:15:error: recursive dependency detected!
> +Kconfig:15: symbol C1 depends on C2
> +Kconfig:19: symbol C2 depends on C1
> +For a resolution refer to Documentation/kbuild/kconfig-language.txt
> +subsection "Kconfig recursive dependency limitations"
> +
> +Kconfig:30:error: recursive dependency detected!
> +Kconfig:30: symbol D2 is selected by D1
> +Kconfig:25: symbol D1 depends on D2
> +For a resolution refer to Documentation/kbuild/kconfig-language.txt
> +subsection "Kconfig recursive dependency limitations"
> +
> +Kconfig:59:error: recursive dependency detected!
> +Kconfig:59: symbol G depends on G
> +For a resolution refer to Documentation/kbuild/kconfig-language.txt
> +subsection "Kconfig recursive dependency limitations"
> +
> +Kconfig:50:error: recursive dependency detected!
> +Kconfig:50: symbol F2 depends on F1
> +Kconfig:48: symbol F1 default value contains F2
> +For a resolution refer to Documentation/kbuild/kconfig-language.txt
> +subsection "Kconfig recursive dependency limitations"
> --
> 2.7.4
>

Besides the missing end quote:

Reviewed-by: Ulf Magnusson <ulfalizer@gmail.com>

\
 
 \ /
  Last update: 2018-02-08 01:16    [W:0.144 / U:7.732 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site