Messages in this thread | | | Subject | Re: [PATCH 1/2] media: adv7604: Add support for i2c_new_secondary_device | From | Kieran Bingham <> | Date | Wed, 7 Feb 2018 15:54:20 +0000 |
| |
Hi Rob,
On 29/01/18 20:08, Rob Herring wrote: > On Mon, Jan 22, 2018 at 12:49:56PM +0000, Kieran Bingham wrote: >> From: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com> >> >> The ADV7604 has thirteen 256-byte maps that can be accessed via the main >> I²C ports. Each map has it own I²C address and acts as a standard slave >> device on the I²C bus. >> >> Allow a device tree node to override the default addresses so that >> address conflicts with other devices on the same bus may be resolved at >> the board description level. >> >> Signed-off-by: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com> >> [Kieran: Re-adapted for mainline] >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >> --- >> Based upon the original posting : >> https://lkml.org/lkml/2014/10/22/469 >> --- >> .../devicetree/bindings/media/i2c/adv7604.txt | 18 ++++++- > > Reviewed-by: Rob Herring <robh@kernel.org>
Thank you.
> In the future, please split bindings to separate patch.
Yes, of course - sorry - I should probably have known better here.
I was clearly being lazy as the original patch had bindings in with the driver. Although I don't think I've got an excuse for the second patch in the series :D
I've split them out for the v2.
-- Kieran
>> drivers/media/i2c/adv7604.c | 60 ++++++++++++++-------- >> 2 files changed, 55 insertions(+), 23 deletions(-) > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |