lkml.org 
[lkml]   [2018]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Resolve RF Type mismatch
On Wed, Feb 07, 2018 at 12:57:13AM +0900, Kangmin Park wrote:
> From: pr0gr4m <l4stpr0gr4m@gmail.com>

No changelog, no sign-off. Changelogs are required but especially in
this case, it's not immediately obvious what this patch is about.

This patch has unrelated white space changes as well. Here is how the
rules work:

> - ODM_1T1R = 0,
> + ODM_1T1R = 0,

This are unrelated.

This white space change is on the same line so that's fine (it's
related).

> - else if ((rf_type == RF_1T2R) || (rf_type ==RF_2T2R))
> + else if ((rf_type == RF_1T2R) || (rf_type == RF_2T2R) || (rf_type == RF_2T2R_GREEN))

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-02-07 11:52    [W:0.036 / U:0.072 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site