lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem
On Tue, Feb 06, 2018 at 03:38:09PM -0800, Eric Biggers wrote:
> I don't think backporting this change for other filesystems is particularly
> important, since if I understand correctly, the reasons that Al made the change
> originally were:
>
> - to allow following symlinks in RCU mode, but that's not implemented in old
> kernels

Yup.

> - to prevent a process from using up all kmaps and deadlocking the system, which
> I'm not sure is a real problem (someone would need to try to put together a
> reproducer), but if so it would probably just be a local device of service.

.. and *that's* only a problem on 32-bit systems. And aside from
Android, it's unclear to me how much we need to support 32-bit systems
on upstream LTS kernels. I suppose there might be Rasperry PI's which
are 32-bits and which might want to use btrfs. Personally I'm not
sure we should care all that much, but others who care more about LTS
kernels and 32-bit systems might have a different opinion.

> Also if we actually backported the full commit there are follow-on fixes such as
> e8ecde25f5e that would be needed as well but might be missed.

Good point.

- Ted

\
 
 \ /
  Last update: 2018-02-07 03:16    [W:0.052 / U:3.420 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site