lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] x86/nospec: Fixup array_index_nospec_mask() asm constraint
On Tue, Feb 6, 2018 at 5:50 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Tue, Feb 6, 2018 at 5:33 PM, Dan Williams <dan.j.williams@intel.com> wrote:
>> Allow the compiler to handle @size as an immediate value rather than
>> allocating a register.
>
> Actually, maybe that "ir" should be "g".
>
> Because it's fine if it's a memory location too. "cmp" takes pretty
> much anything, as long as the thing we compare _to_ is a register.

Ok, no worries I'll do a v2. In fact you suggested 'g' in your initial
version and I lost that along the way while wrestling with why the
compiler miscompiled it until I put it in a static inline rather than
a macro.

\
 
 \ /
  Last update: 2018-02-07 02:55    [W:0.036 / U:0.444 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site