Messages in this thread | | | Subject | Re: [PATCH 2/2] staging: android: ion: Remove lable debugfs_done | From | Laura Abbott <> | Date | Tue, 6 Feb 2018 15:00:22 -0800 |
| |
On 02/01/2018 04:34 AM, Yisheng Xie wrote: > When failed to create debug_root, we will go on initail other part of > ion, so we can just info this message to user and do not need a lable > to jump. >
Acked-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> > --- > drivers/staging/android/ion/ion.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 3e41644..70a70f5 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -601,12 +601,9 @@ static int ion_device_create(void) > } > > idev->debug_root = debugfs_create_dir("ion", NULL); > - if (!idev->debug_root) { > + if (!idev->debug_root) > pr_err("ion: failed to create debugfs root directory.\n"); > - goto debugfs_done; > - } > > -debugfs_done: > idev->buffers = RB_ROOT; > mutex_init(&idev->buffer_lock); > init_rwsem(&idev->lock); >
| |