Messages in this thread | | | Date | Tue, 6 Feb 2018 13:06:53 -0800 | From | Richard Cochran <> | Subject | Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON |
| |
On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote: > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is 1 > and no other possible values of 'tx_type' would match the test. > However, this is more future-proof, should other values be allowed one day.
Nice catch, and I am going to introduce more tx_type values soon.
Thanks, Richard
| |