lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] tpm: add longer timeouts for creation commands.
Date
> 
> On Sun, Jan 28, 2018 at 10:17:39AM +0200, Tomas Winkler wrote:
> > TPM2_CC_Create(0x153) and TPM2_CC_CreatePrimary (0x131) involve
> > generation of crypto keys which can be a computationally intensive task.
> > The timeout is set to 3min.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> This is still NAK because we need some kind of reference for the new value.
> Is that also right value for ARM64/TrustZone based TPMs?

The SPEC itself, doesn't define the timeout, except for specific commands,
also the current 'undefined' number is born in air, I wonder if you can provide the reference as well.
If I would suggest to shorten the number that would maybe a problem for other implementation,
but I don't see how the increase in timeout is adverse another implementations.
Key generation is computational intensive task because of generation of a prime number, so this is really
dependent on device capabilities, so there is no better source of definition that HW itself.

Thanks
Tomas

\
 
 \ /
  Last update: 2018-02-06 21:53    [W:0.033 / U:28.124 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site