lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 5/7] media: i2c: Add TDA1997x HDMI receiver driver
From
Date
On 02/06/2018 09:27 PM, Tim Harvey wrote:
> Add support for the TDA1997x HDMI receivers.
>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---

<snip>

> +static int tda1997x_get_dv_timings_cap(struct v4l2_subdev *sd,
> + struct v4l2_dv_timings_cap *cap)
> +{
> + if (cap->pad != TDA1997X_PAD_SOURCE)
> + return -EINVAL;
> +
> + *cap = tda1997x_dv_timings_cap;
> + return 0;
> +}
> +
> +static int tda1997x_enum_dv_timings(struct v4l2_subdev *sd,
> + struct v4l2_enum_dv_timings *timings)
> +{
> + if (timings->pad != TDA1997X_PAD_SOURCE)
> + return -EINVAL;
> +
> + return v4l2_enum_dv_timings_cap(timings, &tda1997x_dv_timings_cap,
> + NULL, NULL);
> +}

You shouldn't need this pad test: it's done in the v4l2-subdev.c core code
already. But please double-check :-)

Can you post the output of the v4l2-compliance test? I'm curious to see it.

Can you also try to run v4l2-compliance -m /dev/mediaX? That also tests
whether the right entity types are set (note: testing for that should
also happen in the subdev compliance test, but I haven't done that yet).

Regards,

Hans

\
 
 \ /
  Last update: 2018-02-06 21:39    [W:0.085 / U:3.988 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site