lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] printk: Print error pointers as negative integers for %p
On Tue, Feb 6, 2018 at 11:21 AM, David Howells <dhowells@redhat.com> wrote:
> The new hashing feature of unadorned printk("%p") makes it hard to spot if
> the pointer actually carries an error value. Make %p print any pointer
> that matches IS_ERR() as a negative integer.
>
> Should I set SMALL and the field_width as well, I wonder?

> + spec.type = FORMAT_TYPE_INT;

_LONG ?

For sake of consistency.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-02-06 19:52    [W:0.027 / U:2.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site