Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Tue, 6 Feb 2018 19:01:57 +0100 | Subject | Re: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb |
| |
2018-02-06 13:25 GMT+01:00 Alexey Brodkin <Alexey.Brodkin@synopsys.com>: > Hi Bartosz, > > On Tue, 2018-02-06 at 12:08 +0100, Bartosz Golaszewski wrote: >> Using compatible strings without the <manufacturer> part for at24 is >> deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently >> document the compatible property"). Use a correct 'atmel,<model>' >> value. >> >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> > > So my further input might be a bit unexpected :) > > I took a look at the real board and understood that we specified in .dts > wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some > external device) and instead I2C EEPROM we really have connected (but not yet > obviously used in the Linux kernel) is NXP's PCF8594C-2. > > That said we may accept your change because it doesn't break anything > and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes. > Or we may drop your change at all since I'm going to replace corresponding nodes. > > -Alexey
Looks like PCF8594C-2 is compatible with atmel,24c04 - when you'll be submitting this patch, please extend the at24 DT bindings with a new naming exception (just like the one for renesas).
Feel free to drop this patch if you plan to submit the fix soon - otherwise, apply it if it may take some time.
Thanks, Bartosz
| |