lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] extcon: int3496: process id-pin first so that we start with the right status
From
Date
HI,

On 05-02-18 00:28, Chanwoo Choi wrote:
> On 2018년 02월 02일 17:10, Hans de Goede wrote:
>> Hi,
>>
>> On 02-02-18 01:32, Chanwoo Choi wrote:
>>> On 2018년 01월 26일 04:39, Hans de Goede wrote:
>>>> Some other drivers may be waiting for our extcon to show-up (exiting their
>>>> probe methods with -EPROBE_DEFER until we show up).
>>>>
>>>> These drivers will typically get the cable state directly after getting
>>>> the extcon, this commit changes the int3496 code to process the id-pin
>>>> before registering the extcon, so that other drivers see the correct state
>>>> right away.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>> ---
>>>> drivers/extcon/extcon-intel-int3496.c | 7 ++++---
>>>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
>>>> index c8691b5a9cb0..b23ee9d993a3 100644
>>>> --- a/drivers/extcon/extcon-intel-int3496.c
>>>> +++ b/drivers/extcon/extcon-intel-int3496.c
>>>> @@ -131,6 +131,10 @@ static int int3496_probe(struct platform_device *pdev)
>>>> if (IS_ERR(data->gpio_usb_mux))
>>>> dev_info(dev, "can't request USB MUX GPIO\n");
>>>> + /* process id-pin first so that we start with the right status */
>>>> + queue_delayed_work(system_wq, &data->work, 0);
>>>> + flush_delayed_work(&data->work);
>>>> +
>>>> /* register extcon device */
>>>> data->edev = devm_extcon_dev_allocate(dev, int3496_cable);
>>>> if (IS_ERR(data->edev))
>>>> @@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev)
>>>> return ret;
>>>> }
>>>> - /* queue initial processing of id-pin */
>>>> - queue_delayed_work(system_wq, &data->work, 0);
>>>> -
>>>> platform_set_drvdata(pdev, data);
>>>> return 0;
>>>>
>>>
>>> Looks good to me.
>>> How about adding the 'Fixes' commit id on patch description?
>>
>> Right, this could use a:
>>
>> Fixes: 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI device extcon driver")
>>
>
> Please resend this patch Because you need to send the Linux stable mailing list.

Ok, I've just send a v2 with the Fixes and Cc: stable tags added.

Regards,

Hans

\
 
 \ /
  Last update: 2018-02-06 09:12    [W:0.039 / U:0.180 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site