lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate q_depth
Date

> On Feb 6, 2018, at 8:02 AM, Keith Busch <keith.busch@intel.com> wrote:
>
>> On Mon, Feb 05, 2018 at 03:32:23PM -0700, sbates@raithlin.com wrote:
>>
>> - if (dev->cmb && (dev->cmbsz & NVME_CMBSZ_SQS)) {
>> + if (dev->cmb && use_cmb_sqes && (dev->cmbsz & NVME_CMBSZ_SQS)) {
>
> Is this a prep patch for something coming later? dev->cmb is already
> NULL if use_cmb_sqes is false.

Thanks Keith.

Not sure how I missed this. I was working on OOT patches to enable WDS and RDS in the CMB. I *thought* I’d confirmed this patch was applicable to upstream. Looks like I did not do that correctly.

Sorry for the churn. We can leave this patch out for now. Thanks for the prompt feedback everyone!

Stephen
\
 
 \ /
  Last update: 2018-02-06 16:56    [W:0.034 / U:0.024 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site