lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] net, can, ifi: fix "write buffer full" error
From
Date
On 02/06/2018 01:02 PM, Heiko Schocher wrote:
> the driver reads in the ISR first the IRQpending register,
> and clears after that in a write *all* bits in it.
>
> It could happen that the isr register raise bits between
> this 2 register accesses, which leads in lost bits ...
>
> In case it clears "TX message sent successfully", the driver
> never sends any Tx data, and buffers to userspace run over.
>
> Fixed this:
> clear only the bits in the IRQpending register, the
> driver had read.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>

Reviewed-by: Marek Vasut <marex@denx.de>

> ---
>
> drivers/net/can/ifi_canfd/ifi_canfd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/ifi_canfd/ifi_canfd.c b/drivers/net/can/ifi_canfd/ifi_canfd.c
> index 2772d05ff11c..05feb8177936 100644
> --- a/drivers/net/can/ifi_canfd/ifi_canfd.c
> +++ b/drivers/net/can/ifi_canfd/ifi_canfd.c
> @@ -607,7 +607,7 @@ static irqreturn_t ifi_canfd_isr(int irq, void *dev_id)
> return IRQ_NONE;
>
> /* Clear all pending interrupts but ErrWarn */
> - writel(clr_irq_mask, priv->base + IFI_CANFD_INTERRUPT);
> + writel(isr & clr_irq_mask, priv->base + IFI_CANFD_INTERRUPT);
>
> /* RX IRQ or bus warning, start NAPI */
> if (isr & rx_irq_mask) {
>


--
Best regards,
Marek Vasut

\
 
 \ /
  Last update: 2018-02-06 13:51    [W:0.041 / U:0.388 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site