lkml.org 
[lkml]   [2018]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select
On Tue, Feb 6, 2018 at 12:38 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> On Tue, Feb 6, 2018 at 12:25 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
>>
>>> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743
>>> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should
>>> just be selected explicitly if needed.
>>>
>>> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV.
>>>
>>> See commit 0145071b3314 ("x86: Do away with
>>> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do
>>> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well.
>>>
>>> Discovered with the
>>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>>> script.
>>>
>>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>>
>> This should probaly be replaced with
>> select GPIOLIB
>>
>> Yours,
>> Linus Walleij
>
> That'd make more sense if GPIOLIB is actually used. The select has
> been a no-op since mid-2016 at least, but maybe something else selects
> GPIOLIB.
>
> Cheers,
> Ulf

Just replace it with your own patch once you've figured out the proper
fix. More efficient than having a middle man making (sometimes poor)
guesses.

Cheers,
Ulf

\
 
 \ /
  Last update: 2018-02-06 00:49    [W:0.068 / U:3.328 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site