lkml.org 
[lkml]   [2018]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/4] v4l: dvb-frontends: stb0899: fix comparison to bitshift when dealing with a mask
    Date
    Due to a typo, the mask was destroyed by a comparison instead of a bit
    shift.

    Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    ---
    Only build tested. To be applied individually per subsystem.

    drivers/media/dvb-frontends/stb0899_reg.h | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/media/dvb-frontends/stb0899_reg.h b/drivers/media/dvb-frontends/stb0899_reg.h
    index ba1ed56304a0f4..f564269249a682 100644
    --- a/drivers/media/dvb-frontends/stb0899_reg.h
    +++ b/drivers/media/dvb-frontends/stb0899_reg.h
    @@ -374,22 +374,22 @@

    #define STB0899_OFF0_IF_AGC_GAIN 0xf30c
    #define STB0899_BASE_IF_AGC_GAIN 0x00000000
    -#define STB0899_IF_AGC_GAIN (0x3fff < 0)
    +#define STB0899_IF_AGC_GAIN (0x3fff << 0)
    #define STB0899_OFFST_IF_AGC_GAIN 0
    #define STB0899_WIDTH_IF_AGC_GAIN 14

    #define STB0899_OFF0_BB_AGC_GAIN 0xf310
    #define STB0899_BASE_BB_AGC_GAIN 0x00000000
    -#define STB0899_BB_AGC_GAIN (0x3fff < 0)
    +#define STB0899_BB_AGC_GAIN (0x3fff << 0)
    #define STB0899_OFFST_BB_AGC_GAIN 0
    #define STB0899_WIDTH_BB_AGC_GAIN 14

    #define STB0899_OFF0_DC_OFFSET 0xf314
    #define STB0899_BASE_DC_OFFSET 0x00000000
    -#define STB0899_I (0xff < 8)
    +#define STB0899_I (0xff << 8)
    #define STB0899_OFFST_I 8
    #define STB0899_WIDTH_I 8
    -#define STB0899_Q (0xff < 0)
    +#define STB0899_Q (0xff << 0)
    #define STB0899_OFFST_Q 8
    #define STB0899_WIDTH_Q 8

    --
    2.11.0
    \
     
     \ /
      Last update: 2018-02-05 21:12    [W:3.159 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site