Messages in this thread | | | Date | Mon, 5 Feb 2018 11:49:52 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] vsprintf: avoid misleading "(null)" for %px |
| |
On Mon, 5 Feb 2018 16:22:19 +0100 Adam Borowski <kilobyte@angband.pl> wrote:
> My change touches %px only, where your concern doesn't apply. > > You're right, though, when it comes to %pK: > printk("%%pK: %pK, %%px: %px\n", 0, 0); > says > %pK: 00000000ba8bdc0a, %px: 0000000000000000 > > So what should we do? Avoid hashing 0? Print a special value?
My personal opinion is that NULL should stay NULL and not be hashed. What security issue could be leaked by a NULL? I'm not a security person, that's a real question.
-- Steve
| |