lkml.org 
[lkml]   [2018]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: phy-micrel: remove redundant initialization of pointer of_node
On Mon, Feb 05, 2018 at 12:47:59PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer of_node is initialized with a value that is never read, of_node
> is later updated with a new value instead, hence the initialization is
> redundant and can be removed. Also remove unused pointer dev and
> remove an empty line.
>
> Cleans up clang warnings:
> drivers/net/phy/micrel.c:393:28: warning: Value stored to 'of_node'
> during its initialization is never read
> drivers/net/phy/micrel.c:532:28: warning: Value stored to 'of_node'
> during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Hi Colin

You probably need to repost once netdev re-opens.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Andrew

\
 
 \ /
  Last update: 2018-02-05 16:12    [W:0.036 / U:4.528 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site