lkml.org 
[lkml]   [2018]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] ARM: dts: imx25-pinfunc: Always set SION for eSDHC CMD
On Wed, Jan 31, 2018 at 10:35:44PM +0100, Benoît Thébaudeau wrote:
> The eSDHC does not work properly if the SION bit is not set for the
> bidirectional CMD signal, whatever the eSDHC instance and the selected
> pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do
> this for MX25_PAD_*__ESDHCn_CMD in imx25-pinfunc.h in order to enforce
> this behavior for all boards.
>
> This had already been done for eSDHC1, but not for eSDHC2. Also, define
> MX25_PAD_FEC_MDC__ESDHC2_CMD so that all the possible cases are covered
> from now on.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev@gmail.com>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Changes v2 -> v3:
> - Quickly mention SION in each comment, besides the reference to the
> verbose comment (suggested by Uwe).
> Changes v1 -> v2:
> - Update eSDHC instance and port naming following the addition of "ARM:
> dts: imx25-pinfunc: Use consistent naming for eSDHC".
> - Reference the more verbose comment for MX25_PAD_SD1_CMD__ESDHC1_CMD
> instead of copying the same less detailed comment everywhere
> (suggested by Uwe).
> ---
> arch/arm/boot/dts/imx25-pinfunc.h | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2018-02-05 07:10    [W:0.072 / U:0.756 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site