lkml.org 
[lkml]   [2018]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v12 7/9] ACPI: Translate the I/O range of non-MMIO devices before scanning
From
Date
On 05/02/2018 12:10, Joe Perches wrote:
> On Mon, 2018-02-05 at 11:01 +0000, John Garry wrote:
>> On 04/02/2018 07:45, Rafael J. Wysocki wrote:
>>> + /* translate the I/O resources */
>>>> + for (i = 0; i < count; i++) {
>>>> + if (resources[i].flags & IORESOURCE_IO) {
>>>> + ret = acpi_translate_logicio_res(adev, host,
>>>> + &resources[i]);
>>>
>>> You don't need to break this line as far as I'm concerned.
>>
>> This is just to keep checkpatch happy. I could move the complete
>> function call to a single line. And also shortening some symbols will help.
>
> This could also use continue as well
>
> /* translate the I/O resources */
> for (i = 0; i < count; i++) {
> if (!(resources[i].flags & IORESOURCE_IO))
> continue;
> ret = acpi_translate_logicio_res(adev, host, &resources[i]);
> if (ret) {
> kfree(resources);
> dev_err(child, "Translate I/O range failed (%d)!\n",
> ret);
> return ret;
> }
> }

Sure, that reduces the indentation as well.

cheers

>
>
> .
>


\
 
 \ /
  Last update: 2018-02-05 13:38    [W:0.041 / U:1.696 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site