lkml.org 
[lkml]   [2018]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 20/20] x86/PCI: VMD: Fix malformed default
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
>
> Remove the default from VMD instead of changing it. bool and tristate
> symbols implicitly default to n.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> drivers/pci/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
> config VMD
> depends on PCI_MSI && X86_64 && SRCU
> tristate "Intel Volume Management Device Driver"
> - default N
> ---help---
> Adds support for the Intel Volume Management Device (VMD). VMD is a
> secondary PCI host bridge that allows PCI Express root ports,
> --
> 2.14.1
>

The PCIE_ALTERA symbol in this file also depends on the globally
undefined symbol OF_PCI, which was removed in 4670d610d592 ("PCI: Move
OF-related PCI functions into PCI core").

Cheers,
Ulf

\
 
 \ /
  Last update: 2018-02-05 03:03    [W:0.410 / U:68.524 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site