lkml.org 
[lkml]   [2018]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.14 041/110] net/mlx5e: Fix ETS BW check
    Date
    From: Huy Nguyen <huyn@mellanox.com>

    [ Upstream commit ff0891915cd7b24ab27eee9b360c0452853bf9f6 ]

    Fix bug that allows ets bw sum to be 0% when ets tc type exists.

    Fixes: 08fb1dacdd76 ('net/mlx5e: Support DCBNL IEEE ETS')
    Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
    Reviewed-by: Huy Nguyen <huyn@mellanox.com>
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 10 +++++++---
    1 file changed, 7 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c b/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c
    index 51c4cc00a186..9d64d0759ee9 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c
    @@ -259,6 +259,7 @@ int mlx5e_dcbnl_ieee_setets_core(struct mlx5e_priv *priv, struct ieee_ets *ets)
    static int mlx5e_dbcnl_validate_ets(struct net_device *netdev,
    struct ieee_ets *ets)
    {
    + bool have_ets_tc = false;
    int bw_sum = 0;
    int i;

    @@ -273,11 +274,14 @@ static int mlx5e_dbcnl_validate_ets(struct net_device *netdev,
    }

    /* Validate Bandwidth Sum */
    - for (i = 0; i < IEEE_8021QAZ_MAX_TCS; i++)
    - if (ets->tc_tsa[i] == IEEE_8021QAZ_TSA_ETS)
    + for (i = 0; i < IEEE_8021QAZ_MAX_TCS; i++) {
    + if (ets->tc_tsa[i] == IEEE_8021QAZ_TSA_ETS) {
    + have_ets_tc = true;
    bw_sum += ets->tc_tx_bw[i];
    + }
    + }

    - if (bw_sum != 0 && bw_sum != 100) {
    + if (have_ets_tc && bw_sum != 100) {
    netdev_err(netdev,
    "Failed to validate ETS: BW sum is illegal\n");
    return -EINVAL;
    --
    2.11.0
    \
     
     \ /
      Last update: 2018-02-03 19:48    [W:2.270 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site