lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 022/254] usb: host: fix incorrect updating of offset
    3.16.55-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit 1d5a31582ef046d3b233f0da1a68ae26519b2f0a upstream.

    The variable temp is incorrectly being updated, instead it should
    be offset otherwise the loop just reads the same capability value
    and loops forever. Thanks to Alan Stern for pointing out the
    correct fix to my original fix. Fix also cleans up clang warning:

    drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp'
    is never read

    Fixes: d49d43174400 ("USB: misc ehci updates")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/host/ehci-dbg.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/host/ehci-dbg.c
    +++ b/drivers/usb/host/ehci-dbg.c
    @@ -850,7 +850,7 @@ static ssize_t fill_registers_buffer(str
    default: /* unknown */
    break;
    }
    - temp = (cap >> 8) & 0xff;
    + offset = (cap >> 8) & 0xff;
    }
    }
    #endif
    \
     
     \ /
      Last update: 2018-02-28 16:55    [W:6.662 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site