lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v16 03/11] fw_cfg: fix sparse warning reading FW_CFG_ID
    Date
    Use a restricted type for reading FW_CFG_ID, fixing sparse warning:

    drivers/firmware/qemu_fw_cfg.c:540:22: warning: cast to restricted __le32

    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    ---
    drivers/firmware/qemu_fw_cfg.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
    index 7978844f6b37..0eb155fdfb35 100644
    --- a/drivers/firmware/qemu_fw_cfg.c
    +++ b/drivers/firmware/qemu_fw_cfg.c
    @@ -530,6 +530,7 @@ static inline void fw_cfg_kobj_cleanup(struct kobject *kobj)
    static int fw_cfg_sysfs_probe(struct platform_device *pdev)
    {
    int err;
    + __le32 rev;

    /* NOTE: If we supported multiple fw_cfg devices, we'd first create
    * a subdirectory named after e.g. pdev->id, then hang per-device
    @@ -555,8 +556,8 @@ static int fw_cfg_sysfs_probe(struct platform_device *pdev)
    goto err_probe;

    /* get revision number, add matching top-level attribute */
    - fw_cfg_read_blob(FW_CFG_ID, &fw_cfg_rev, 0, sizeof(fw_cfg_rev));
    - fw_cfg_rev = le32_to_cpu(fw_cfg_rev);
    + fw_cfg_read_blob(FW_CFG_ID, &rev, 0, sizeof(rev));
    + fw_cfg_rev = le32_to_cpu(rev);
    err = sysfs_create_file(fw_cfg_top_ko, &fw_cfg_rev_attr.attr);
    if (err)
    goto err_rev;
    --
    2.16.1.73.g5832b7e9f2
    \
     
     \ /
      Last update: 2018-02-28 16:14    [W:4.247 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site