lkml.org 
[lkml]   [2018]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 02/11] test_firmware: replace syfs fallback check with kconfig_has helper
    On Fri, Feb 23, 2018 at 6:46 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
    > Now that we have a kconfig checker just use that instead of relying
    > on testing a sysfs directory being present, since our requirements
    > are spelled out.

    I don't see the reason to depend on config.gz, but it's a reasonable
    requirement for a test build.

    > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>

    Acked-by: Kees Cook <keescook@chromium.org>

    -Kees

    > ---
    > tools/testing/selftests/firmware/fw_fallback.sh | 5 +----
    > 1 file changed, 1 insertion(+), 4 deletions(-)
    >
    > diff --git a/tools/testing/selftests/firmware/fw_fallback.sh b/tools/testing/selftests/firmware/fw_fallback.sh
    > index a42e437363d9..40b6c1d3e832 100755
    > --- a/tools/testing/selftests/firmware/fw_fallback.sh
    > +++ b/tools/testing/selftests/firmware/fw_fallback.sh
    > @@ -49,10 +49,7 @@ kconfig_has()
    >
    > DIR=/sys/devices/virtual/misc/test_firmware
    >
    > -# CONFIG_FW_LOADER_USER_HELPER has a sysfs class under /sys/class/firmware/
    > -# These days no one enables CONFIG_FW_LOADER_USER_HELPER so check for that
    > -# as an indicator for CONFIG_FW_LOADER_USER_HELPER.
    > -HAS_FW_LOADER_USER_HELPER=$(if [ -d /sys/class/firmware/ ]; then echo yes; else echo no; fi)
    > +HAS_FW_LOADER_USER_HELPER=$(kconfig_has CONFIG_FW_LOADER_USER_HELPER=y)
    > HAS_FW_LOADER_USER_HELPER_FALLBACK=$(kconfig_has CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y)
    >
    > if [ "$HAS_FW_LOADER_USER_HELPER" = "yes" ]; then
    > --
    > 2.16.2
    >



    --
    Kees Cook
    Pixel Security

    \
     
     \ /
      Last update: 2018-02-28 00:10    [W:2.994 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site