lkml.org 
[lkml]   [2018]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/11] kexec_file: Remove checks in kexec_purgatory_load
    Date
    Before the purgatory is loaded several checks are done whether the ELF file
    in kexec_purgatory is valid or not. These checks are incomplete. For
    example they don't check for the total size of the sections defined in the
    section header table or if the entry point actually points into the
    purgatory.

    On the other hand the purgatory, although an ELF file on its own, is part
    of the kernel. Thus not trusting the purgatory means not trusting the
    kernel build itself.

    So remove all validity checks on the purgatory and just trust the kernel
    build.

    Signed-off-by: Philipp Rudo <prudo@linux.vnet.ibm.com>
    ---
    kernel/kexec_file.c | 14 --------------
    1 file changed, 14 deletions(-)

    diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
    index e5bcd94c1efb..0f044457b40c 100644
    --- a/kernel/kexec_file.c
    +++ b/kernel/kexec_file.c
    @@ -880,22 +880,8 @@ int kexec_load_purgatory(struct kimage *image, unsigned long min,
    if (kexec_purgatory_size <= 0)
    return -EINVAL;

    - if (kexec_purgatory_size < sizeof(Elf_Ehdr))
    - return -ENOEXEC;
    -
    pi->ehdr = (Elf_Ehdr *)kexec_purgatory;

    - if (memcmp(pi->ehdr->e_ident, ELFMAG, SELFMAG) != 0
    - || pi->ehdr->e_type != ET_REL
    - || !elf_check_arch(pi->ehdr)
    - || pi->ehdr->e_shentsize != sizeof(Elf_Shdr))
    - return -ENOEXEC;
    -
    - if (pi->ehdr->e_shoff >= kexec_purgatory_size
    - || (pi->ehdr->e_shnum * sizeof(Elf_Shdr) >
    - kexec_purgatory_size - pi->ehdr->e_shoff))
    - return -ENOEXEC;
    -
    ret = __kexec_load_purgatory(image, min, max, top_down);
    if (ret)
    return ret;
    --
    2.13.5
    \
     
     \ /
      Last update: 2018-02-26 16:27    [W:4.051 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site