Messages in this thread | | | From | Kai-Heng Feng <> | Date | Sun, 25 Feb 2018 23:45:01 +0800 | Subject | Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore |
| |
On Sun, Feb 25, 2018 at 11:18 PM, Matthew Wilcox <willy@infradead.org> wrote: > On Sun, Feb 25, 2018 at 08:38:33PM +0800, Kai-Heng Feng wrote: >> v2: Use in-kernel tolower() function. > > ... why are you using tolower at all? > > You've got 13 quirks already; you may need to use upper case as well > before too long.
Makes sense. I'll remove tolower() in next version.
> >> + quirk = vmalloc(sizeof(struct quirk_entry)); > > vmalloc? For a struct that's 24 bytes? You know that allocates an > entire 4k page, right? >
Right, I'll use kmalloc() instead. Or is there any more efficient malloc function?
| |