lkml.org 
[lkml]   [2018]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/7] struct page: add field for vm_struct
    On Fri, Feb 23, 2018 at 04:48:03PM +0200, Igor Stoppa wrote:
    > @@ -1769,6 +1771,9 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
    >
    > kmemleak_vmalloc(area, size, gfp_mask);
    >
    > + for (i = 0; i < area->nr_pages; i++)
    > + area->pages[i]->area = area;
    > +
    > return addr;
    >
    > fail:

    IMO, this is the wrong place to initialise the page->area. It should be
    done in __vmalloc_area_node() like so:

    area->nr_pages = i;
    goto fail;
    }
    + page->area = area;
    area->pages[i] = page;
    if (gfpflags_allow_blocking(gfp_mask))
    cond_resched();

    \
     
     \ /
      Last update: 2018-02-25 04:39    [W:4.020 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site