lkml.org 
[lkml]   [2018]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 140/145] usb: phy: msm add regulator dependency
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>

    On linux-4.4 and linux-4.9 we get a warning about an array that is
    never initialized when CONFIG_REGULATOR is disabled:

    drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_probe':
    drivers/usb/phy/phy-msm-usb.c:1911:14: error: 'regs[0].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    motg->vddcx = regs[0].consumer;
    ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    drivers/usb/phy/phy-msm-usb.c:1912:14: error: 'regs[1].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    motg->v3p3 = regs[1].consumer;
    ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    drivers/usb/phy/phy-msm-usb.c:1913:14: error: 'regs[2].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    motg->v1p8 = regs[2].consumer;

    This adds a Kconfig dependency for it. In newer kernels, the driver no
    longer exists, so this is only needed for stable kernels.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/phy/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/usb/phy/Kconfig
    +++ b/drivers/usb/phy/Kconfig
    @@ -147,6 +147,7 @@ config USB_MSM_OTG
    depends on (USB || USB_GADGET) && (ARCH_QCOM || COMPILE_TEST)
    depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y'
    depends on RESET_CONTROLLER
    + depends on REGULATOR
    depends on EXTCON
    select USB_PHY
    help

    \
     
     \ /
      Last update: 2018-02-23 20:42    [W:3.588 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site