lkml.org 
[lkml]   [2018]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 138/159] spi: sun4i: disable clocks in the remove function
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takuo Koguchi <takuo.koguchi@gmail.com>


    [ Upstream commit c810daba0ab5226084a56893a789af427a801146 ]

    mclk and hclk need to be disabled. Since pm_runtime_disable does
    not disable the clocks, use pm_runtime_force_suspend instead.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@hitachi.com>
    Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/spi/spi-sun4i.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/spi/spi-sun4i.c
    +++ b/drivers/spi/spi-sun4i.c
    @@ -525,7 +525,7 @@ err_free_master:

    static int sun4i_spi_remove(struct platform_device *pdev)
    {
    - pm_runtime_disable(&pdev->dev);
    + pm_runtime_force_suspend(&pdev->dev);

    return 0;
    }

    \
     
     \ /
      Last update: 2018-02-23 20:15    [W:4.043 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site