Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 23 Feb 2018 15:35:01 +0200 | Subject | Re: [PATCH v4 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform |
| |
On Fri, Feb 23, 2018 at 6:44 AM, Baolin Wang <baolin.wang@linaro.org> wrote: > The Spreadtrum SC9860 platform GPIO controller contains 16 groups and > each group contains 16 GPIOs. Each GPIO can set input/output and has > the interrupt capability. >
Sorry, couple comments below.
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> +/* We have 16 banks GPIOs and each bank contain 16 GPIOs */ > +#define SPRD_GPIO_BANK_NR 16 > +#define SPRD_GPIO_NR 256
> +#define SPRD_GPIO_BANK_SIZE 0x80
128 ?
> + irq->handler = handle_simple_irq;
Shouldn't be handle_bad_irq() ?
> +static const struct of_device_id sprd_gpio_of_match[] = { > + { .compatible = "sprd,sc9860-gpio", },
> + { /* end of list */ },
Comma is redundant. Absence of it even better at compile time if at some weird case the item goes after a terminator.
> +};
-- With Best Regards, Andy Shevchenko
| |