lkml.org 
[lkml]   [2018]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] pci: endpoint: Free func_name after last usage


    On Wed, 21 Feb 2018, Andy Shevchenko wrote:

    > > Change-Id: I0d1b6fd652395b85f82b11c43bf9b7db512854d1
    >
    > First of all, this shouldn't be here.
    >
    Please excuse me. I know that I have to remove this, but
    unfortunately I forgot to do so (here and also in the other patch).

    > > Signed-off-by: Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>
    > > Signed-off-by: Rolf Evers-Fischer <embedded24@evers-fischer.de>
    >
    > Looks like bipolar disorder?
    >
    You are right: One "Signed-off" should be enough.

    > To the topic.
    > This is a slow path and your change makes code slightly less readable
    > b/c of patterns used in the kernel.
    >
    I see. It is probably not a good idea to free the
    memory in the middle of the function.
    If you don't mind, I will remove this patch and change the other
    one accordingly.

    With best regards,
    Rolf Evers-Fischer

    \
     
     \ /
      Last update: 2018-02-22 17:22    [W:2.214 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site