Messages in this thread | | | Date | Thu, 22 Feb 2018 16:44:32 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH NAND v4] mtd: nand: Replace printk() with appropriate pr_*() macro |
| |
On Thu, 22 Feb 2018 20:59:27 +0530 Shreeya Patel <shreeya.patel23498@gmail.com> wrote:
> The log levels embedded with the name are more concise than > printk.
If you don't mind, I'll replace the above sentence by:
" Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>). "
The patch looks good otherwise, so I should apply it soon.
If you're okay, and Julia and Ezequiel are okay too, I'd like to move to the next step and have you work on an ->exec_op() conversion (jz4780?).
Of course, that does not prevent you from continuing the printk()/dev_xx() conversion.
-- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
| |