Messages in this thread | | | Date | Thu, 22 Feb 2018 21:42:31 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 2/2] crypto: bcm: One function call less in do_shash() after error detection |
| |
On Wed, Feb 14, 2018 at 10:40:26PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 14 Feb 2018 22:22:20 +0100 > > The kfree() function was called in one case by the do_shash() function > during error handling even if the passed variable contained a null pointer. > > * Reorder two function calls at the end. > > * Add a jump target.
This patch is pointless as kfree on NULL is a no-op.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |