lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 03/16] of: dynamic: Add __of_node_dupv()
    Hi Laurent,

    On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart
    <laurent.pinchart+renesas@ideasonboard.com> wrote:
    > From: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
    >
    > Add an __of_node_dupv() private method and make __of_node_dup() use it.
    > This is required for the subsequent changeset accessors which will
    > make use of it.
    >
    > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
    > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    > ---
    > drivers/of/dynamic.c | 29 +++++++++++++++++++++++------
    > 1 file changed, 23 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
    > index 7bb33d22b4e2..4ffd04925fdf 100644
    > --- a/drivers/of/dynamic.c
    > +++ b/drivers/of/dynamic.c
    > @@ -382,8 +382,9 @@ struct property *__of_prop_dup(const struct property *prop, gfp_t allocflags)
    > }
    >
    > /**
    > - * __of_node_dup() - Duplicate or create an empty device node dynamically.
    > - * @fmt: Format string (plus vargs) for new full name of the device node
    > + * __of_node_dupv() - Duplicate or create an empty device node dynamically.
    > + * @fmt: Format string for new full name of the device node
    > + * @vargs: va_list containing the arugments for the node full name
    > *
    > * Create an device tree node, either by duplicating an empty node or by allocating
    > * an empty one suitable for further modification. The node data are
    > @@ -391,17 +392,15 @@ struct property *__of_prop_dup(const struct property *prop, gfp_t allocflags)
    > * OF_DETACHED bits set. Returns the newly allocated node or NULL on out of
    > * memory error.
    > */
    > -struct device_node *__of_node_dup(const struct device_node *np, const char *fmt, ...)
    > +struct device_node *__of_node_dupv(const struct device_node *np,

    static, cfr.
    https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=topic/overlays&id=c45324e1807dd708344c9a478b777b68aca11cdf

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2018-02-21 11:27    [W:2.843 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site