lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
    From
    Date


    On 02/19/2018 05:38 PM, Farhan Ali wrote:
    >
    >
    > On 02/19/2018 11:25 AM, Thomas Huth wrote:
    >> On 19.02.2018 16:47, Farhan Ali wrote:
    >>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")'
    >>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the
    >>> "Graphics support" menu for S390. But if we enable VT layer for S390,
    >>> we would also need to enable the dummy console. So let's remove the
    >>> HAS_IOMEM dependency.
    >>>
    >>> Move this dependency to sub menu items and console drivers that use
    >>> io memory.
    >>>
    >>> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
    >>> ---
    >>>   drivers/video/Kconfig         | 21 +++++++++++----------
    >>>   drivers/video/console/Kconfig |  4 ++--
    >>>   2 files changed, 13 insertions(+), 12 deletions(-)
    >>>
    >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
    >>> index 3c20af9..8f10915 100644
    >>> --- a/drivers/video/Kconfig
    >>> +++ b/drivers/video/Kconfig
    >>> @@ -3,7 +3,6 @@
    >>>   #
    >>>     menu "Graphics support"
    >>> -    depends on HAS_IOMEM
    >>>     config HAVE_FB_ATMEL
    >>>       bool
    >>> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL
    >>>   config SH_LCD_MIPI_DSI
    >>>       bool
    >>>   -source "drivers/char/agp/Kconfig"
    >>> +if HAS_IOMEM
    >>> +    source "drivers/char/agp/Kconfig"
    >>>   -source "drivers/gpu/vga/Kconfig"
    >>> +    source "drivers/gpu/vga/Kconfig"
    >>>   -source "drivers/gpu/host1x/Kconfig"
    >>> -source "drivers/gpu/ipu-v3/Kconfig"
    >>> +    source "drivers/gpu/host1x/Kconfig"
    >>> +    source "drivers/gpu/ipu-v3/Kconfig"
    >>>   -source "drivers/gpu/drm/Kconfig"
    >>> +    source "drivers/gpu/drm/Kconfig"


    Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need still more
    work.

    \
     
     \ /
      Last update: 2018-02-21 11:06    [W:4.515 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site