Messages in this thread | | | Subject | Re: [PATCH] doc: process: Add "Root-caused-by" and "Suggested-by" | From | Randy Dunlap <> | Date | Wed, 21 Feb 2018 20:43:54 -0800 |
| |
On 02/21/2018 04:37 PM, Kees Cook wrote: > As recently pointed out by Linus, "Root-caused-by" is a good tag to include > since it can indicate significantly more work than "just" a Reported-by. > This adds it and "Suggested-by" (which was also missing) to the documented > list of tags. Additionally updates checkpatch.pl to match the process docs. > > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > Documentation/process/5.Posting.rst | 7 +++++++ > scripts/checkpatch.pl | 2 ++ > 2 files changed, 9 insertions(+)
I would still rather see Co-developed-by: in both the docs and in checkpatch. :(
> diff --git a/Documentation/process/5.Posting.rst b/Documentation/process/5.Posting.rst > index 645fa9c7388a..2ff01f76f02a 100644 > --- a/Documentation/process/5.Posting.rst > +++ b/Documentation/process/5.Posting.rst > @@ -234,6 +234,13 @@ The tags in common use are: > people who test our code and let us know when things do not work > correctly. > > + - Suggested-by: names a person who suggested the solution, but may not > + have constructed the full patch. A weaker version of `Co-Developed-by`. > + > + - Root-caused-by: names a person who diagnosed the root cause of a > + problem. This usually indicates significantly more work than a simple > + `Reported-by`. > + > - Cc: the named person received a copy of the patch and had the > opportunity to comment on it. > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 3d4040322ae1..a1ab82e70b54 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -464,9 +464,11 @@ our $logFunctions = qr{(?x: > our $signature_tags = qr{(?xi: > Signed-off-by:| > Acked-by:| > + Co-Developed-by:| > Tested-by:| > Reviewed-by:| > Reported-by:| > + Root-caused-by:| > Suggested-by:| > To:| > Cc: >
-- ~Randy
| |