Messages in this thread | | | Date | Tue, 20 Feb 2018 13:29:56 -0600 | From | Josh Poimboeuf <> | Subject | Re: [PATCH 0/5] x86/dumpstack: Cleanups and user opcode bytes Code: section |
| |
On Tue, Feb 20, 2018 at 07:14:00PM +0000, Andy Lutomirski wrote: > On Mon, Feb 19, 2018 at 8:28 PM, Borislav Petkov <bp@alien8.de> wrote: > > From: Borislav Petkov <bp@suse.de> > > > > Hi, > > > > so I've been thinking about doing this for a while now: be able to dump > > the opcode bytes around the user rIP just like we do for kernel faults. > > > > Why? > > > > See patch 5's commit message. That's why I've marked it RFC. > > > > The rest is cleanups: we're copying the opcodes byte-by-byte and that's > > just wasteful. > > Maybe this series already has this side-effect, but I'd really love to > see oopses show the code bytes for each kernel entry, not just the > innermode one. We already dump full regs including RIP -- adding > Code: should be easy and would be very helpful.
Just to clarify, I think you want to show the Code: around regs->ip every time we show the registers?
-- Josh
| |