lkml.org 
[lkml]   [2018]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFCv4 11/21] media: v4l2_fh: add request entity field
From
Date
On 02/20/18 05:44, Alexandre Courbot wrote:
> Allow drivers to assign a request entity to v4l2_fh. This will be useful
> for request-aware ioctls to find out which request entity to use.
>
> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> ---
> include/media/v4l2-fh.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/media/v4l2-fh.h b/include/media/v4l2-fh.h
> index ea73fef8bdc0..f54cb319dd64 100644
> --- a/include/media/v4l2-fh.h
> +++ b/include/media/v4l2-fh.h
> @@ -28,6 +28,7 @@
>
> struct video_device;
> struct v4l2_ctrl_handler;
> +struct media_request_entity;
>
> /**
> * struct v4l2_fh - Describes a V4L2 file handler
> @@ -43,6 +44,7 @@ struct v4l2_ctrl_handler;
> * @navailable: number of available events at @available list
> * @sequence: event sequence number
> * @m2m_ctx: pointer to &struct v4l2_m2m_ctx
> + * @entity: the request entity this fh operates on behalf of
> */
> struct v4l2_fh {
> struct list_head list;
> @@ -60,6 +62,7 @@ struct v4l2_fh {
> #if IS_ENABLED(CONFIG_V4L2_MEM2MEM_DEV)
> struct v4l2_m2m_ctx *m2m_ctx;
> #endif
> + struct media_request_entity *entity;

The name 'media_request_entity' is very confusing.

In the media controller API terminology an entity represents a piece
of hardware with inputs and outputs (very rough description), but a
request is not an entity. It may be associated with an entity, though.

So calling this field 'entity' is also very misleading.

As with previous patches, I'll have to think about this and try and
come up with better, less confusing names.

Regards,

Hans

> };
>
> /**
>

\
 
 \ /
  Last update: 2018-02-20 16:25    [W:0.298 / U:33.980 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site